System.Printing does not consume lib assemblies from WPF GitHub package #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific WPF GitHub package.
ghost
requested review from
ghost
added
the
rladuca
added
Bug
vatsan-madhavan
approved these changes
Jun 25, 2019
|
I recommend not waiting for Helix based tests to complete. It doesn't give you any value and likely going to block you for hours when the tests run for < 2 mins. The core build seems to have passed. Consider overriding policies and merging. |
ryalanms
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating generated CppCliHelper project to reference and use RID-specific WPF GitHub package.
This is the WpfArcadeSdk piece of the change. The latest commit in https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int/pullrequest/1772?_a=overview contains the internal piece of the fix.
Fixes #1079