-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Removal of permissions and types housed in System.Security.Permissions.dll #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to get a full DRT run on these changes?
src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/AppModel/CustomCredentialPolicy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/AppModel/SiteOfOriginContainer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/ISecureCommand.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/Microsoft/Win32/FileDialog.cs
Outdated
Show resolved
Hide resolved
|
||
if (launched == LaunchResult.NotLaunched) | ||
throw; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we don't need to still catch the exception and set LaunchResult
to NotLaunched
before rethrowing the exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to set LaunchResult to anything since we now have full trust on WebPermission and the local variable is not useful anymore. I re-added catching the exception and just throw now
src/Microsoft.DotNet.Wpf/test/DRT/DrtXaml/DrtXaml/Tests/BasicXamlTests.cs
Outdated
Show resolved
Hide resolved
A quick grep in the repo shows this. Mostly benign comments and
|
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/InterOp/HwndSource.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/MediaSystem.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/Printing/printdlgexmarshaler.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off with the proviso that we think a bit about PrintQueue.InPartialTrust being set to true.
The other comments are more code cleanup than anything, I don't feel strongly about it.
Looks like you've found DRT failures. Let's hold this PR for Preview 7 and continue our snap, and then resume as soon as P8 master opens up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've found DRT failures. Let's hold this PR for Preview 7 and continue our snap, and then resume as soon as P8 master opens up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing approval due to test failures.
…s.dll (#1093) * removed permissions * removed securitypolicy imports * removed most security exceptions * some IL found changes * more IL located removal * removed imports from tests * removed package reference * more IL found removals * removed XmlSyntaxException * addressed comments
…s.dll (#1093) * removed permissions * removed securitypolicy imports * removed most security exceptions * some IL found changes * more IL located removal * removed imports from tests * removed package reference * more IL found removals * removed XmlSyntaxException * addressed comments
Part of #241
Left PackageReference to System.Security.Permissions in
System.Xaml.csproj
andSystem.Xaml-ref.csproj
for now due toXamlAccessLevel
and typeforwarding.