Fix issues flagged by Policheck #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
vatsan-madhavan
added
the
* NO MERGE *
stevenbrix
changed the title
stevenbrix
force-pushed
the
dev/stevenbrix/sdl-fixes-release
branch
from
79d951e to
4443be5
Compare
vatsan-madhavan
removed
the
* NO MERGE *
|
@stevenbrix - this is good to merge as soon as build passes. |
vatsan-madhavan
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes policheck bugs assigned to us via the SDL build step. There were a lot more issues identified, but only these 5 issues were actually relevant and worth fixing. The other issues aren't actually offensive or used in the incorrect context.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969303/
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969349/
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969362/
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969298/
Customer Impact
Potentially offensive terms
Regression
No
Risk
None. Only affects comments
Fixes #1696