Skip to content

Initial repo docs #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 30, 2018
Merged

Initial repo docs #32

merged 6 commits into from
Nov 30, 2018

Conversation

karelz
Copy link
Member

@karelz karelz commented Nov 29, 2018

  • Adding Getting started and Issue guide docs
  • Added README.md sections Quick Links, Port Status and security bugs reporting info
  • Scoped .NET Core 3.0 work to parity with WPF for .NET Framework

Overall modeled after similar docs update in WinForms repo: dotnet/winforms#100

Not covered yet:

  • Contribution guide

fabiant3-zz
fabiant3-zz reviewed Nov 30, 2018
View reviewed changes
Copy link

@fabiant3-zz fabiant3-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have "Getting started with WPF for .NET Core" on title and WARNING: ,,,XAML Designer support for WPF on .NET Core
Do you want to change title to WPF on .NET Core (on)? How is Winforms?

Otherwise this looks good to me.

@karelz
Copy link
Member Author

karelz commented Nov 30, 2018

Feedback addressed.
@fabiant3 I was going there and back in this spot, because of the double for "for WPF for .NET Core". We mostly used "for", so that is what I prefer everywhere else. I changed the instance to the "double for".

@karelz karelz merged commit c3707f0 into dotnet:master Nov 30, 2018
@karelz karelz deleted the docs branch November 30, 2018 01:50
@ptorr-msft
Copy link
Contributor

LGTM, thanks for adding all the extra info. I can abandon my PR now I assume?

@karelz karelz mentioned this pull request Nov 30, 2018
Closed
@karelz
Copy link
Member Author

karelz commented Nov 30, 2018

@ptorr-msft I made comments in your PR about the parts I left out: #23 (comment) ... let's discuss it there

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rladuca rladuca rladuca left review comments

@vatsan-madhavan vatsan-madhavan vatsan-madhavan approved these changes

@fabiant3-zz fabiant3-zz fabiant3-zz approved these changes

@ptorr-msft ptorr-msft Awaiting requested review from ptorr-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karelz @ptorr-msft @rladuca @vatsan-madhavan @fabiant3-zz