Skip to content

Contributing guide #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Contributing

See [Contributing Guide](../Documentation/contributing-guide.md) for information about:

* Which kind of PRs we accept/reject for .NET Core 3.0 release
* Coding style
* PR style preferences (squashing vs. merging, etc.)
* Developer guide for building and testing locally
19 changes: 19 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
name: Bug report
about: Create a report to help us improve
---

* .NET Core Version: (e.g. 3.0 Preview1, or daily build number, use `dotnet --info`)
* Windows version: (`winver`)
* Does the bug reproduce also in WPF for .NET Framework 4.8?: Yes/No

<!-- Read https://github.com/dotnet/wpf/blob/master/Documentation/issue-guide.md -->

**Problem description:**

**Actual behavior:** <!-- callstack for crashes / exceptions -->

**Expected behavior:**

**Minimal repro:**

6 changes: 6 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
name: Feature / API request
about: Suggest an idea for this project
---

<!-- Read https://github.com/dotnet/wpf/blob/master/Documentation/issue-guide.md -->
46 changes: 46 additions & 0 deletions Documentation/contributing-guide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Contributing Guide

Primary focus of .NET Core 3.0 release is to achieve parity with WPF for .NET Framework.
Since we're currently still porting parts of WPF codebase (incl. tests) to GitHub (see progress at [../README.md#port-status]),
we're not ready to handle non-trivial or larger contributions beyond parity fixes yet.

We plan to accept these kind of contributions during 3.0 release:

* Low-risk changes, which are easy to review (e.g. typos, comment changes, documentation improvements, etc.).
* Test fixes, test improvements and new tests increasing code coverage.
* Infrastructure fixes and improvements, which are aligned with achieving our goal to ship high quality .NET Core 3.0 release.
* Bug fixes for differences between WinForms for .NET Core and .NET Framework.

If you have a **larger change** falling into any of these categories, we recommend to **check with our team members** prior to creating a PR.
We recommend to first create a [new issue](https://github.com/dotnet/wpf/issues), where you can describe your intent and help us understand the change you plan to contribute.

**WARNING:** Expect that we may reject or postpone PRs which do not align with our primary focus (parity with WPF for .NET Framework),
or which could introduce unnecessary risk (e.g. in code which is historically sensitive, or is not well covered by tests).
Such PRs may be closed and reconsidered later after we ship .NET Core 3.0.



## Developer Guide

Before you start, please review [WPF contributing doc](TODO) and **[.NET Core contributing doc](https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/contributing.md)** for coding style and PR gotchas.

* Per-machine setup: [Machine setup](#machine-setup) and [Fork and clone repo](https://github.com/dotnet/corefx/wiki/Checking-out-the-code-repository)
* [Build and run tests](#build-and-run-tests)
* [git commands and workflow](https://github.com/dotnet/corefx/wiki/git-reference) - for newbies on GitHub
* Pick issue: [up-for-grabs](https://github.com/dotnet/wpf/issues?q=is%3Aopen+is%3Aissue+label%3Aup-for-grabs) or [easy](https://github.com/dotnet/wpf/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3Aeasy)
* [Coding guidelines](https://github.com/dotnet/corefx/tree/master/Documentation#coding-guidelines)

### Machine Setup

TODO

### Build and run tests

#### To build

In the root of your repo, run `build.cmd` (or `build.cmd -verbose` for logs).

#### To run tests

In the root of your repo, run `test.cmd` or open the solution file `src\Microsoft.DotNet.Wpf\test\DRT\DrtXaml.sln` ("DRT" is an internal name used for unit tests).
* Note that this will test the version of `System.Xaml.dll` currently installed in your shared framework; if you rebuild `System.Xaml.dll` and want to test your changes, you will need to replace the current DLL with your own (be sure to make a backup first).
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,12 @@ For general .NET Core 3 issues (not specific to WPF), use the [.NET Core repo](h

### Contributing Guide

**TODO**
Read our detailed [contributing guide](Documentation/contributing-guide.md) which covers:

For more details, take a look at the [.NET Core Contribution Guidelines](https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/contributing.md).
* Which kind of PRs we accept/reject for .NET Core 3.0 release
* Coding style
* PR style preferences (squashing vs. merging, etc.)
* Developer guide for building and testing locally

### Community

Expand Down