Skip to content

Add NoTestFileCreate property in FileDialog #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add NoTestFileCreate property in FileDialog #3975

wants to merge 1 commit into from

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Jan 10, 2021

Fix #870

I don’t know if this property is appropriate

@lindexi lindexi requested a review from a team as a code owner January 10, 2021 14:33
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 10, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent January 10, 2021 14:33
ryalanms
ryalanms requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@ryalanms ryalanms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make summary formatting consistent with the rest of the file, and consider updating this property to TestFileCreate similar to DereferenceLinks.

@ryalanms
Copy link
Member

Although this is a minor modification, it is a public API change and requires an API review.

@miloush
Copy link
Contributor

miloush commented Jan 18, 2021 •
edited
Loading

I would suggest the name to be reconsidered. A similar flag, OFN_NODEREFERENCELINKS is represented by DereferenceLinks so OFN_NOTESTFILECREATE should follow the suite, perhaps as CreateTestFile or similar.

@lindexi
Copy link
Member Author

lindexi commented Jan 19, 2021

@ryalanms @miloush Thank you. How about ShouldCreateTestFile ?

@ryalanms
Copy link
Member

Adding @MikeHillberg for API review...

Base automatically changed from master to main March 17, 2021 17:38
@pchaurasia14 pchaurasia14 added the Community Contribution A label for all community Contributions label Jul 20, 2022
@ghost ghost assigned lindexi Jul 20, 2022
@dipeshmsft
Copy link
Member

@lindexi, since the corresponding PR #7916 has been merged for this, I am closing this PR. Nevertheless, thanks for your efforts. We hope to see more contributions from you in the future.

@lindexi
Copy link
Member Author

lindexi commented Jul 10, 2023 •
edited
Loading

Thank you @dipeshmsft and @miloush

@lindexi lindexi closed this Jul 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryalanms ryalanms ryalanms requested changes

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@lindexi lindexi

Labels
API Review Requested Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SaveFileDialog support NOTESTFILECREATE.
5 participants
@lindexi @ryalanms @miloush @dipeshmsft @pchaurasia14