Skip to content

Replace Obsolete APIs #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

Replace Obsolete APIs #5234

wants to merge 24 commits into from

Conversation

singhashish-wpf
Copy link
Member

Fixes Issue #3660
Main PR #4968

Description

SYSLIB0028(https://docs.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0028)
X509Certificate2.PrivateKey is obsolete, Need to throw an exception when the private key can't be retrieved.

Customer Impact

Regression

No

Testing

Build, CI/CD, Locally tested DRTs/Microsuite.

Risk

dotnet-maestro bot and others added 23 commits August 18, 2021 03:50
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
34816bf 
…10817.9 (#5098)

[release/6.0-rc1] Update dependencies from dotnet/winforms
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
6d4450b 
…otnet-wpf-int build 20210817.10 (#5102)

[release/6.0-rc1] Update dependencies from dnceng/internal/dotnet-wpf-int
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
7703941 
…10818.7 (#5112)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21417.1 to 6.0.0-rc.1.21418.7 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
5991094 
…10818.14 (#5116)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21418.7 to 6.0.0-rc.1.21418.17 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
799d80d 
…818.12 (#5121)

[release/6.0-rc1] Update dependencies from dotnet/arcade
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
f68efe7 
…otnet-wpf-int build 20210819.3 (#5122)

[release/6.0-rc1] Update dependencies from dnceng/internal/dotnet-wpf-int
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
c1f930c 
…10819.4 (#5124)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21418.17 to 6.0.0-rc.1.21419.3 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
4d50cfa 
…10820.2 (#5131)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21419.3 to 6.0.0-rc.1.21420.7 (parent: Microsoft.Private.Winforms)
@ryalanms
Accessibility: Port "GetClickablePoint returns error value when the e…
afd0727 
…lement is offscreen" from main (#5130)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
04d5051 
…10823.1 (#5145)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21420.7 to 6.0.0-rc.1.21421.1 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
b65cdc5 
…10823.12 (#5151)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21421.1 to 6.0.0-rc.1.21423.9 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
50fb028 
…10824.7 (#5157)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21423.9 to 6.0.0-rc.1.21423.21 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
d5013fb 
…10824.8 (#5158)

[release/6.0-rc1] Update dependencies from dotnet/winforms
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
d04fb52 
…10824.11 (#5159)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21423.21 to 6.0.0-rc.1.21424.10 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
0c4d481 
…10825.7 (#5169)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21424.10 to 6.0.0-rc.1.21424.15 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
7ca62fe 
…10825.15 (#5175)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21424.15 to 6.0.0-rc.1.21425.7 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
0e0bf10 
…10825.16 (#5180)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21425.7 to 6.0.0-rc.1.21425.15 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
fa13a2f 
…10825.22 (#5185)

[release/6.0-rc1] Update dependencies from dotnet/winforms
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
0660667 
…10826.4 (#5193)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21425.15 to 6.0.0-rc.1.21426.8 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
7fa466e 
…10826.8 (#5200)

[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21426.17 (parent: Microsoft.Private.Winforms)
@dotnet-maestro
[release/6.0-rc1] Update dependencies from dotnet/winforms (#5208)
8fa13be 
[release/6.0-rc1] Update dependencies from dotnet/winforms
- Coherency Updates:
  - System.CodeDom: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Diagnostics.EventLog: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.DirectoryServices: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Drawing.Common: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Security.Cryptography.Xml: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Security.Permissions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Windows.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.IO.Packaging: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - System.Resources.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
  - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)

 - Remove Analyzers coming from net6.0 ref pack

These require VS 2022 Roslyn v4.0, but the CI machine is still using VS 2019.
@eerhardt
Respond to PR feedback from #5208 (#5225)
d26acd0
@singhashish-wpf
Replace Obsolete APIs
3f4f3a2
@singhashish-wpf singhashish-wpf requested a review from a team as a code owner September 1, 2021 11:08
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 1, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent September 1, 2021 11:08
@ryalanms ryalanms mentioned this pull request Sep 3, 2021
Open
@ryalanms
Copy link
Member

ryalanms commented Sep 3, 2021

Does this match the exception behavior of the replaced call?

@singhashish-wpf
Copy link
Member Author

@ryalanms
The replaced call (cert.privateKey which is obsolete now) was able to throw multiple exceptions (CryptographicException, ArgumentNullException, ArgumentException).
ArgumentException is being thrown in this case as the same is being thrown in an analogous situation in the same file here

The exception behavior couldn't be reproduced locally after creating a certificate with null key usng makecert tool.

@ryalanms ryalanms changed the base branch from release/6.0-rc1 to release/6.0 September 14, 2021 16:08
@singhashish-wpf singhashish-wpf added this to the .NET 6.0 Servicing milestone Sep 14, 2021
@singhashish-wpf singhashish-wpf modified the milestones: .NET 6.0 Servicing, .NET 7.0 Nov 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
@karelz karelz modified the milestones: .NET 7.0, 7.0.0 Sep 15, 2023
@ghost ghost assigned singhashish-wpf Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@singhashish-wpf singhashish-wpf

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@singhashish-wpf @ryalanms @karelz @eerhardt