Fix ResX Code Generation #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et GenerateResxSource to true so that codegen runs on our EmbeddedResources. This is blocking some DARC PRs with the latest Arcade changes.
ryalanms
approved these changes
May 7, 2019
|
@vatsan-madhavan There is only one knob, the GenerateResxSource property. I left GenerateSource set EmbeddedResource since, otherwise, we'd have to wait for DARC flow to get things working. With both in there, we get current builds succeeding + builds with the new Arcade stuff. Once that is pushed everywhere I can remove GenerateSource if we want. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in Arcade in GenerateResxSource.targets, we need to set GenerateResxSource to true so that codegen runs on our EmbeddedResources. This is blocking some DARC PRs with the latest Arcade changes.
fixes #662