Skip to content

Hollowed out public types extending from System.Security.Permissions types #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ojhad merged 11 commits into from
Jun 13, 2019
Merged

Hollowed out public types extending from System.Security.Permissions types #869

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
79964a2
hollowed out public types
Jun 4, 2019
36702df
addressed comments
Jun 6, 2019
91173d8
Merge branch 'master' into user/ojhad/securitypermissionspublicapi
Jun 7, 2019
7423e99
fixed tests
Jun 8, 2019
8d2d94b
fixed formatting
Jun 8, 2019
1d17e12
removed SR dependency from XamlAccessLevel
Jun 10, 2019
a6a6701
stripped XamlAccessLevel of CAS functionality
Jun 10, 2019
37fb782
changes to hollow permissions
Jun 11, 2019
e098bc3
minor change
Jun 12, 2019
1ce15d8
updated implementation
Jun 12, 2019
b52083a
addressed comment
Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Permissions/XamlLoadPermission.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ public sealed class XamlLoadPermission : CodeAccessPermission, IUnrestrictedPerm
public XamlLoadPermission(PermissionState state) { }
public XamlLoadPermission(XamlAccessLevel allowedAccess) { }
public XamlLoadPermission(IEnumerable<XamlAccessLevel> allowedAccess) { }
[ComVisible(false)]
public override bool Equals(object obj) { return false; }
Copy link

@weltkante weltkante Jun 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a valid implementation because x.Equals(x) returns false, which will cause all sorts of bugs if anyone calls this method. You should use ReferenceEquals(this, obj) or throw an exception if you don't want to support equality.

Copy link
Member

@vatsan-madhavan vatsan-madhavan Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This impl. will get deleted from dotnet/wpf shortly, and we'll consume the one from dotnet/corefx#38405. Let's make sure we get the corefx PR right.

[ComVisible(false)]
public override int GetHashCode() { return base.GetHashCode(); }
public IList<XamlAccessLevel> AllowedAccess {get; private set;} = new ReadOnlyCollection<XamlAccessLevel>(Array.Empty<XamlAccessLevel>());
public override IPermission Copy() { return new XamlLoadPermission(PermissionState.Unrestricted); }
public override void FromXml(SecurityElement elem) { }
Expand Down