[Draft] Enabling Fluent as default theme using an opt-in and app.config #9332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and NavigationWindow styles
…default-all-static
dotnet-policy-service
bot
added
the
PR
|
Closing this PR for now, will take this up once we have added the missing control styles. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE : This shows how the changes will look like for enabling fluent as default. This doesn't mean these are final and neither that we will disable the implicit loading method available currently.
This PR includes the changes that will be required to make "Enabling Fluent as default theme" possible. There are parts of it that will be done differently while making the final changes, but this here is to show what are the minimal changes that will be required to make the above possible.
The PR consists of various commits and changes in PR can be divided into different parts :
Customer Impact
This will allow developers to load Fluent themes as default styles and it will allow them to test the capabilities and the gaps in the new theme, which we would then want to fix in the next .NET release.
Regression
No
Testing
Still pending. Also, there are a few things that are missing from this PR - like using Fluent theme when HighContrast mode is on, DataGrid style is not loading. I will fix this in coming weeks.
Risk
Since, we made some changes in the way SystemResources behave, there may be some issues that can come up. Need to wrap the SystemResource changes inside the Fluent app context flag as well.
Microsoft Reviewers: Open in CodeFlow