Skip to content

Add GetAllKeysByPrefix to InMemory and Redis #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 30, 2022
Merged

Add GetAllKeysByPrefix to InMemory and Redis #422

merged 4 commits into from
Nov 30, 2022

Conversation

meysamhadeli
Copy link
Contributor

Hi.
I added this feature #397 to EasyCahing.

  • Add getall (inMemory - redis)
  • Add getall-keys (inMemory - redis)

@meysamhadeli
- add getall (inMemory - redis)
1f81f6b 
- add getall-keys (inMemory - resis)
@meysamhadeli meysamhadeli changed the title - add getall (inMemory - redis) & - Add GetAll (inMemory - redis) & Add GetAllKeys (inMemory - redis) Nov 17, 2022
@meysamhadeli meysamhadeli changed the title - Add GetAll (inMemory - redis) & Add GetAllKeys (inMemory - redis) Add GetAll & Add GetAllKeys to InMemory and Redis Nov 17, 2022
@meysamhadeli meysamhadeli changed the title Add GetAll & Add GetAllKeys to InMemory and Redis Add GetAll & GetAllKeys to InMemory and Redis Nov 17, 2022
@catcherwong catcherwong self-requested a review November 19, 2022 07:40
@meysamhadeli
Copy link
Contributor Author

Hi.
Is this any problem with this pull request?

@catcherwong
Copy link
Member

Still in the review, maybe need one more day.

@meysamhadeli
Copy link
Contributor Author

Still in the review, maybe need one more day.

Ok, Thanks :)

catcherwong
catcherwong requested changes Nov 21, 2022
View reviewed changes
@meysamhadeli
Copy link
Contributor Author

I refactor all issue in my code and sent a pull request for that :)

Full changeset is here:
8c70b43

@meysamhadeli meysamhadeli changed the title Add GetAll & GetAllKeys to InMemory and Redis Add GetAllKeysByPrefix to InMemory and Redis Nov 23, 2022
@meysamhadeli
Copy link
Contributor Author

meysamhadeli commented Nov 23, 2022 •
edited
Loading

I removed all methods with optional prefix parameter and only add these two methods:

  • GetAllKeysByPrefix
  • GetAllKeysByPrefixAsync

Full changeset is here:
d40f6bf

@catcherwong catcherwong merged commit 7b63e26 into dotnetcore:dev Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catcherwong catcherwong catcherwong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meysamhadeli @catcherwong