Skip to content

Update react-scripts, eslint, typescript, rollup deps #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 15, 2021

Conversation

rpoet-ds
Copy link
Contributor

@rpoet-ds rpoet-ds commented Dec 8, 2021

https://dotsub.atlassian.net/browse/VTMS-3439

The large number of file changes is because of a change in importing React, it is no longer needed and typescript flags it as an error:

microsoft/TypeScript#41882
https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

I ran npx react-codemod update-react-imports to update the react imports.

@rpoet-ds rpoet-ds self-assigned this Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #252 (27501c3) into master (a4c2971) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #252     +/-   ##
========================================
+ Coverage    99.9%   99.9%   +0.1%     
========================================
  Files          85      85             
  Lines        2329    2347     +18     
  Branches      567     584     +17     
========================================
+ Hits         2326    2344     +18     
  Misses          3       3             
Impacted Files Coverage Δ
src/subtitleEdit/CompleteButton.tsx 100.0% <ø> (ø)
src/subtitleEdit/SubtitleEdit.tsx 100.0% <ø> (ø)
src/subtitleEdit/SubtitleEditHeader.tsx 100.0% <ø> (ø)
src/subtitleEdit/TooltipWrapper.tsx 100.0% <ø> (ø)
src/subtitleEdit/common/DateTime.tsx 92.4% <ø> (ø)
src/subtitleEdit/cues/CueErrorAlert.tsx 100.0% <ø> (ø)
src/subtitleEdit/cues/CueErrorLine.tsx 100.0% <ø> (ø)
src/subtitleEdit/cues/comments/CueComments.tsx 100.0% <ø> (ø)
src/subtitleEdit/cues/cueLine/CueActionsPanel.tsx 100.0% <ø> (ø)
src/subtitleEdit/cues/cueLine/CueLine.tsx 100.0% <ø> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c2971...27501c3. Read the comment docs.

@rpoet-ds rpoet-ds merged commit 40b5036 into master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants