Skip to content

chore: add expo example #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feat/media3-newarch
Choose a base branch
from

Conversation

thedv91
Copy link

@thedv91 thedv91 commented Jul 11, 2025

What does this PR do?

This PR adds a minimal Expo monorepo project to reproduce a runtime error on Android related to react-native-track-player.

What’s included?

  • A sample Expo app inside apps/example-expo
  • Uses the local react-native-track-player package via workspace:.
  • Configures Metro bundler for monorepo resolution
  • Runs with expo prebuild to generate native code

How to reproduce

  1. Install dependencies:

    yarn install
  2. Start app on Android:

    yarn example:expo android
  3. Click the play button and check the logs in the terminal

@thedv91 thedv91 requested a review from dcvz as a code owner July 11, 2025 18:16
@thedv91 thedv91 mentioned this pull request Jul 11, 2025
5 tasks
@jspizziri
Copy link
Collaborator

@thedv91 , thanks for this. Going to try to take a look at it this week.

@thedv91
Copy link
Author

thedv91 commented Jul 21, 2025

@jspizziri It seems the issue was related to maxCacheSize, and I can see that you've already fixed it.

Thanks for addressing this!

@jspizziri
Copy link
Collaborator

@thedv91 great news.

I'm still interested in this PR in general as adding anexpo example to the project would be helpful. In order to do that I'd want to refactor the existing structure a bit. Specifically:

apps/example -> apps/expo // (expo example)
example -> apps/bare // (bare rn example)
apps/shared // (some sort of shared example components folder sared between expo and bare)

Is that something you'd be able to contribute to?

@thedv91
Copy link
Author

thedv91 commented Jul 22, 2025

@jspizziri Sounds great! Happy to help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants