This repository was archived by the owner on Dec 31, 2019. It is now read-only.
Repository navigation
Remove process.exit(0) from processEnding to fix false positives on CI server - #113
Open
nathanmarks wants to merge 1 commit into
Open
nathanmarks wants to merge 1 commit into
nathanmarks wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI, there were already 4 failing tests -- this patch didn't cause those.
Using
substack/tapeas an example, the test harness listens forprocess.exitbefore printing results, and conditionally callingprocess.exit()with a non zero exit code.I noticed that with a failing tests,
tapedoes not even print the results because the exit routine is hijacked:At the moment, the
processEndingfunction incover.jscauses the process to exit with an exit code of0(as long as istanbul has no errors with coverage). As a consequence, the tests are assumed to have finished without error. This means that generating coverage on travis (or any other CI server) requires running the test suite twice unless you want to get false positives.Correct me if I'm wrong -- but removing this
process.exit()call shouldn't affect any users unless their test suite hangs by itself.