Merge in shdict CAS PR #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/ngx_http_lua_shdict.c
doc: add balancer_by_lua*, ssl_certificate_by_lua* to the context of some api
doc: fix log_by_lua, runs before nginx access log and after
…Lua string value "http" in this module.
…nges. now ignoring request bodies indeed trigger disgarding the body upon request finalization.
…aborted prematurely (via ngx.exit, for example) while a light thread is still waiting on ngx.flush(true).
…he ngx_connection_t object which MIGHT lead to socket leaks.
Small documentation fix to sample code
…. Portwood II and Tomas Kvasnicka for the report in openresty#669 and openresty#668, respectively.
… "dynamic modules" in NGINX 1.9.11+.
…X 1.9.11+ via the --add-dynamic-module=PATH option of ./configure.
…ficiate_by_lua* and some ngx.ssl API functions that are not supported by LibreSSL. thanks George Liu for the report in openresty#654 and Bret for the report in openresty/openresty#148.
…t of init_by_lua*.
|
Sorry, my bad. |
doujiang24
pushed a commit
that referenced
this pull request
Jun 29, 2021
…found by coverity
deref_ptr: Directly dereferencing pointer c.
419 if (c->addr_text.len) {
420 p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text);
421 len -= p - buf;
422 buf = p;
423 }
424
CID 149837 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
425 if (c && c->listening && c->listening->addr_text.len) {
426 p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text);
427 /* len -= p - buf; */
428 buf = p;
429 }
doujiang24
pushed a commit
that referenced
this pull request
Jun 29, 2021
…esty#1846) 734 buf = p; 735 deref_ptr: Directly dereferencing pointer c. 736 if (c->addr_text.len) { 737 p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text); 738 len -= p - buf; 739 buf = p; 740 } 741 CID 149839 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 742 if (c && c->listening && c->listening->addr_text.len) { 743 p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text); 744 /* len -= p - buf; */ 745 buf = p; 746 }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.