Admin protocol updates #1948
Admin protocol updates #1948
Conversation
| ('config_names', String('utf-8')), | ||
| ('config_value', String('utf-8')), | ||
| ('read_only', Boolean), | ||
| ('config_source', Int8), |
There was a problem hiding this comment.
It looks like this was renamed from is_default to config_source, and the type changed from Boolean to Int8 in v1 as well, but I didn't include that fix here. Should I?
There was a problem hiding this comment.
Ugh. I do hate to make breaking changes... But I could go either way on this one.
TylerLubeck
force-pushed
the
admin-protocol-updates
branch
from
c51d814 to
68d8aad
Compare
TylerLubeck
force-pushed
the
admin-protocol-updates
branch
from
68d8aad to
fa35d52
Compare
|
I know how this sounds, but I can't for the life of me reproduce the test failure locally. Any suggestions? |
python > 3.3 will error at runtime so while this test is extraneous it'll help catch typos like this
|
Test failure is known to be flakey and has been marked as xfail in master (see #1929) |
dpkp
left a comment
dpkp
left a comment
There was a problem hiding this comment.
Looks great! I haven't been following the latest protocol changes... why are there so many version bumps with no changes to request/response schemas?
| ('config_names', String('utf-8')), | ||
| ('config_value', String('utf-8')), | ||
| ('read_only', Boolean), | ||
| ('config_source', Int8), |
There was a problem hiding this comment.
Ugh. I do hate to make breaking changes... But I could go either way on this one.
| useful for avoiding extra network round trips if you already know | ||
| the group coordinator. This is only useful when all the group_ids | ||
| have the same coordinator, otherwise it will error. Default: None. | ||
| :param include_authorized_operatoins: Whether or not to include |
2 participants
I've been digging in to the admin client and found myself adding extra api version support
This change is