Skip to content

Improve sticky assignor's test coverage #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aynroot
Copy link
Contributor

@aynroot aynroot commented Nov 4, 2020

A follow up for #2154 with test coverage


This change is Reviewable

aynroot and others added 2 commits November 4, 2020 11:53
Use six.viewitems instead of six.iteritems to avoid encoding problems (dpkp#2154)
@aynroot
Copy link
Contributor Author

aynroot commented Nov 4, 2020

@jeffwidman this should cover the #2154 fix
I've checked for any other gaps in coverage, but it looks pretty good atm

Copy link
Contributor

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, thank you!

@jeffwidman jeffwidman merged commit b090b21 into dpkp:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants