bugfix: fix infinite loop on KafkaAdminClient #2194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An infinite loop may happen with the following pattern:
self._send_request_to_node(self._client.least_loaded_node(), request)
The problem happens when `self._client`'s cluster metadata is out-of-date, and the
result of `least_loaded_node()` is a node that has been removed from the cluster but
the client is unware of it. When this happens `_send_request_to_node` will enter an
infinite loop waiting for the chosen node to become available, which won't happen,
resulting in an infinite loop.
This commit introduces a new method named `_send_request_to_least_loaded_node` which
handles the case above. This is done by regularly checking if the target node is
available in the cluster metadata, and if not, a new node is chosen.
Notes:
- This does not yet cover every call site to `_send_request_to_node`, there are some
other places were similar race conditions may happen.
- The code above does not guarantee that the request itself will be sucessful, since
it is still possible for the target node to exit, however, it does remove the
infinite loop which can render client code unusable.
If the value `_controller_id` is out-of-date and the node was removed from the cluster, `_send_request_to_node` would enter an infinite loop.
hackaugusto
added a commit
to aiven/kafka-python
that referenced
this pull request
Jan 18, 2021
An infinite loop may happen with the following pattern:
self._send_request_to_node(self._client.least_loaded_node(), request)
The problem happens when `self._client`'s cluster metadata is out-of-date, and the
result of `least_loaded_node()` is a node that has been removed from the cluster but
the client is unware of it. When this happens `_send_request_to_node` will enter an
infinite loop waiting for the chosen node to become available, which won't happen,
resulting in an infinite loop.
This commit introduces a new method named `_send_request_to_least_loaded_node` which
handles the case above. This is done by regularly checking if the target node is
available in the cluster metadata, and if not, a new node is chosen.
Notes:
- This does not yet cover every call site to `_send_request_to_node`, there are some
other places were similar race conditions may happen.
- The code above does not guarantee that the request itself will be sucessful, since
it is still possible for the target node to exit, however, it does remove the
infinite loop which can render client code unusable.
hackaugusto
added a commit
to aiven/kafka-python
that referenced
this pull request
Jan 18, 2021
If the value `_controller_id` is out-of-date and the node was removed from the cluster, `_send_request_to_node` would enter an infinite loop.
rushidave
pushed a commit
to aiven/kafka-python
that referenced
this pull request
Jan 3, 2024
If the value `_controller_id` is out-of-date and the node was removed from the cluster, `_send_request_to_node` would enter an infinite loop.
rushidave
pushed a commit
to aiven/kafka-python
that referenced
this pull request
Feb 29, 2024
An infinite loop may happen with the following pattern:
self._send_request_to_node(self._client.least_loaded_node(), request)
The problem happens when `self._client`'s cluster metadata is out-of-date, and the
result of `least_loaded_node()` is a node that has been removed from the cluster but
the client is unware of it. When this happens `_send_request_to_node` will enter an
infinite loop waiting for the chosen node to become available, which won't happen,
resulting in an infinite loop.
This commit introduces a new method named `_send_request_to_least_loaded_node` which
handles the case above. This is done by regularly checking if the target node is
available in the cluster metadata, and if not, a new node is chosen.
Notes:
- This does not yet cover every call site to `_send_request_to_node`, there are some
other places were similar race conditions may happen.
- The code above does not guarantee that the request itself will be sucessful, since
it is still possible for the target node to exit, however, it does remove the
infinite loop which can render client code unusable.
rushidave
pushed a commit
to aiven/kafka-python
that referenced
this pull request
Feb 29, 2024
If the value `_controller_id` is out-of-date and the node was removed from the cluster, `_send_request_to_node` would enter an infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2193
An infinite loop may happen with the following pattern:
The problem happens when
self._client's cluster metadata is out-of-date, and theresult of
least_loaded_node()is a node that has been removed from the cluster butthe client is unware of it. When this happens
_send_request_to_nodewill enter aninfinite loop waiting for the chosen node to become available, which won't happen,
resulting in an infinite loop.
This commit introduces a new method named
_send_request_to_least_loaded_nodewhichhandles the case above. This is done by regularly checking if the target node is
available in the cluster metadata, and if not, a new node is chosen.
Notes:
_send_request_to_node, there are someother places were similar race conditions may happen.
it is still possible for the target node to exit, however, it does remove the
infinite loop which can render client code unusable.
This change is