fix: line number in syntax error message from external formatter #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsherret PTAL |
kt3k
deleted the
fix-line-number-when-syntax-error-from-external-formatter
branch
kt3k
added a commit
to denoland/deno
that referenced
this pull request
Jun 11, 2025
…rom external formatter (#29698) The line number in error message is off by one when external formatter raised syntax error. This commit fixes it by upgrading `dprint-plugin-typescript` (The issue was fixed in upstream dprint/dprint-plugin-typescript#722 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the line number in error message when external formatter raised syntax error
related: denoland/deno#29660 (comment)