Skip to content

refactor(BREAKING): external formatter accepts string instead of MediaType #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

refactor(BREAKING): external formatter accepts string instead of MediaType #723

merged 2 commits into from
Jun 23, 2025

Conversation

bartlomieju
Copy link
Collaborator

Working on denoland/deno#29851 (comment)
I realized it's not possible to support any tagged template without first
updating dprint-plugin-typescript and possibly deno_media_type.

@dsherret dsherret changed the title feat(BREAKING): external formatter accepts string instead of MediaType refactor(BREAKING): external formatter accepts string instead of MediaType Jun 23, 2025
dsherret
dsherret approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 44a8302 into dprint:main Jun 23, 2025
2 checks passed
@bartlomieju bartlomieju deleted the external_formatter branch June 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret