-
Notifications
You must be signed in to change notification settings - Fork 767
Conversation
Signed-off-by: yeya24 <[email protected]>
@@ -9,8 +9,3 @@ script: | |||
|
|||
# after_success: | |||
# - bash <(curl -s https://codecov.io/bash) || echo "Failed to report code coverage!" | |||
|
|||
cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to delete this, is this related to pouchlinter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I think this config is for previous Java version. Do we still need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. While could you help to confirm that? @lowzj
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 46.95% 46.93% -0.02%
==========================================
Files 115 115
Lines 6954 6954
==========================================
- Hits 3265 3264 -1
Misses 3434 3434
- Partials 255 256 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
update pouchlinter to 0.2.4
update pouchlinter to 0.2.4
Signed-off-by: yeya24 [email protected]
Ⅰ. Describe what this PR did
Update pouchlinter
Ⅱ. Does this pull request fix one issue?
fixes #989
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews