Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

update pouchlinter to 0.2.4 #1009

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

yeya24
Copy link
Collaborator

@yeya24 yeya24 commented Oct 17, 2019

Signed-off-by: yeya24 [email protected]

Ⅰ. Describe what this PR did

Update pouchlinter

Ⅱ. Does this pull request fix one issue?

fixes #989

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added size/XS LGTM one maintainer or community participant agrees to merge the pull reuqest. labels Oct 17, 2019
@@ -9,8 +9,3 @@ script:

# after_success:
# - bash <(curl -s https://codecov.io/bash) || echo "Failed to report code coverage!"

cache:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to delete this, is this related to pouchlinter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think this config is for previous Java version. Do we still need that?

Copy link
Contributor

@allencloud allencloud Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. While could you help to confirm that? @lowzj

@allencloud allencloud removed the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #1009 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   46.95%   46.93%   -0.02%     
==========================================
  Files         115      115              
  Lines        6954     6954              
==========================================
- Hits         3265     3264       -1     
  Misses       3434     3434              
- Partials      255      256       +1
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 21.91% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b120a8...1ecd2cf. Read the comment docs.

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@allencloud allencloud merged commit e6351e3 into dragonflyoss:master Oct 17, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update golang 1.12.6 to 1.12.10
5 participants