Python pkg #2
Merged
Python pkg #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit generalizes the approach originally introduced in e880bf0 to prevent the development files from being installed when building the python package.
This will ensure that executable will be available after installed the wheel. The approach adapted from scikit-build/cmake-python-distributions and scikit-build/ninja-python-distribution projects. For more details, see https://setuptools.readthedocs.io/en/latest/setuptools.html#automatic-script-creation
This is useful when developing locally.
dralley
pushed a commit
that referenced
this pull request
Feb 17, 2019
Addressing 2: 2: ====================================================================== 2: ERROR: test_crfile_xz_compression (tests.test_crfile.TestCaseCrFile) 2: ---------------------------------------------------------------------- 2: Traceback (most recent call last): 2: File "/src/tests/python/tests/test_crfile.py", line 104, in test_crfile_xz_compression 2: p = subprocess.Popen(["unxz", "--stdout", path], stdout=subprocess.PIPE) 2: File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__ 2: restore_signals, start_new_session) 2: File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child 2: raise child_exception_type(errno_num, err_msg, err_filename) 2: FileNotFoundError: [Errno 2] No such file or directory: 'unxz': 'unxz' 2: 2: ====================================================================== 2: ERROR: test_crfile_zck_compression (tests.test_crfile.TestCaseCrFile) 2: ---------------------------------------------------------------------- 2: Traceback (most recent call last): 2: File "/src/tests/python/tests/test_crfile.py", line 120, in test_crfile_zck_compression 2: p = subprocess.Popen(["unzck", "--stdout", path], stdout=subprocess.PIPE) 2: File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__ 2: restore_signals, start_new_session) 2: File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child 2: raise child_exception_type(errno_num, err_msg, err_filename) 2: FileNotFoundError: [Errno 2] No such file or directory: 'unzck': 'unzck' 2: 2: ====================================================================== 2: ERROR: test_xmlfile_xz_compression (tests.test_xml_file.TestCaseXmlFile) 2: ---------------------------------------------------------------------- 2: Traceback (most recent call last): 2: File "/src/tests/python/tests/test_xml_file.py", line 131, in test_xmlfile_xz_compression 2: p = subprocess.Popen(["unxz", "--stdout", path], stdout=subprocess.PIPE) 2: File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__ 2: restore_signals, start_new_session) 2: File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child 2: raise child_exception_type(errno_num, err_msg, err_filename) 2: FileNotFoundError: [Errno 2] No such file or directory: 'unxz': 'unxz' 2: 2: ====================================================================== 2: ERROR: test_xmlfile_zck_compression (tests.test_xml_file.TestCaseXmlFile) 2: ---------------------------------------------------------------------- 2: Traceback (most recent call last): 2: File "/src/tests/python/tests/test_xml_file.py", line 149, in test_xmlfile_zck_compression 2: p = subprocess.Popen(["unzck", "--stdout", path], stdout=subprocess.PIPE) 2: File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__ 2: restore_signals, start_new_session) 2: File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child 2: raise child_exception_type(errno_num, err_msg, err_filename) 2: FileNotFoundError: [Errno 2] No such file or directory: 'unzck': 'unzck' 2: 2: ---------------------------------------------------------------------- 2: Ran 96 tests in 0.179s 2: 2: FAILED (errors=4) 2/2 Test #2: test_python ......................***Failed 0.44 sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.