Auto-detect dimension names from DataArray, remove bracket-spec API - #17
Conversation
drbenvincent
left a comment
There was a problem hiding this comment.
Good simplification — auto-detecting dims from the DataArray is cleaner than the bracket-spec, and the implementation is correct. A few issues to address before merging.
|
Version bump needed — removing the bracket-spec API ( Also worth adding a one-line migration note to the changelog / release notes so users know what to change. |
* Add Altair demo tab to landing page * Enable vegafusion data transformer for large Altair datasets * Fix Altair rendering: vegafusion, vl-convert, and faceted chart sizing
1dcb8b2 to
5f312ab
Compare
|
Bumped to 0.3.0 in both |
Closes #11. Dimensions are now read from the xarray DataArray and spread automatically — no bracket syntax needed.
What changed
_parse_var_spec()(~35 lines of regex + dimension validation)import re,from typing import Tuple, Listparameter_draws: accepts bare*var_names— auto-detects non-sample dims fromDataArray.dimscompare_draws: follows via delegation, renamed*var_specs→*var_namesprediction_draws: docstring no longer misleadingly mentions bracket syntaxtest_error_malformed_spec,test_error_dimension_mismatch(both test files); all specs updated to bare names.qmdfiles +AGENTS.mdupdatedVerification