Remove version pin from arviz dependency - #27
Merged
Conversation
Remove the floor from the arviz dependency in pyproject.toml. With no version floor, pip never upgrades an existing arviz install (any version satisfies the constraint), so installing tidydraws cannot corrupt the user's arviz/numpy/xarray environment. This resolves the packaging concern raised in #26 (now closed): the install-corruption problem only arises when the declared floor is above what the user has installed. No floor means no upgrade. The entire Bayesian audience already has arviz (PyMC depends on it), so declaring arviz as a dependency is honest — the core extraction path needs it to run. The no-arviz edge user (xarray + hand-built DataTree) gets arviz pulled, which is expected and correct. Closes #26. See #19 for the broader extraction-engine discussion.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
>=0.12floor from thearvizdependency inpyproject.toml:Why
With no version floor, pip never upgrades an existing arviz install — any version satisfies the constraint. This means installing tidydraws cannot corrupt the user's arviz/numpy/xarray environment, which is the problem #26 was opened to solve.
The corruption mechanism only triggers when the declared floor is above what the user has installed (e.g.
arviz>=1.0would force-upgrade an arviz 0.14 user, pullingnumpy>=2andxarray>=2024.11viaarviz_base). No floor → no upgrade → no corruption.The entire Bayesian audience already has arviz (PyMC depends on it), so declaring it as a dependency is honest. The no-arviz edge user (xarray + hand-built
DataTree, no PyMC) gets arviz pulled on install — which is correct, since the core extraction path uses it.This resolves the packaging question without lazy-import gymnastics, PEP 621 extras, or version-floor debates. The remaining
arviz.extractdelegation decision (tracked in #19) is now a pure maintenance tradeoff — shim cost + upstream coupling vsnum_samples+ ArviZ API consistency — unencumbered by packaging concerns.Verification
uv lockresolves cleanly.Related