Skip to content

Conversation

@samsonasik
Copy link
Collaborator

@samsonasik samsonasik commented Dec 10, 2025

@peterfox per your feedback at #443 (comment)

This move to use NodeVisitor over global Node. Here the benefit and drawback:

Benefit:

  • can reuse class constant attribute over rules if needed.

Drawback:

  • The default config is included in sets, but if user just want to use some rule that require the attribute, user need to import the default config:
->withSets([
     __DIR__ . '/vendor/driftingly/rector-laravel/config/config.php'
])
->withRules([
     // the rule from this repo :)
]);

I've updated readme for it tho.

@samsonasik
Copy link
Collaborator Author

@GeniJaho @driftingly @peterfox ready for review/merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant