WebVirtualDirectory: Using WebApplication with blank or slash #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `Set-TargetResource` switch between `WebApplication` '' and '/' as required by `New-WebVirtualDirectory` and `Remove-WebVirtualDirectory` respectively. Fix dsccommunity#366
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
===================================
Coverage 88% 88%
===================================
Files 15 15
Lines 1940 1944 +4
===================================
+ Hits 1710 1714 +4
Misses 230 230
|
johlju
changed the title
johlju
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tommysor)
|
Thanks for this change. |
Clay10J
pushed a commit
to Clay10J/WebAdministrationDsc
that referenced
this pull request
Dec 5, 2023
) - WebVirtualDirectory [Issue dsccommunity#366](dsccommunity#366) In WebVirtualDirectory WebApplication '' and '/' can now be used interchangeably. - Fixed Add WebVirtualDirectory when WebApplication = '/'. - Fixed Remove WebVirtualDirectory when WebApplication = ''.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Make
Set-TargetResourceswitch betweenWebApplication'' and '/' as required byNew-WebVirtualDirectoryandRemove-WebVirtualDirectoryrespectively.This Pull Request (PR) fixes the following issues
Fix #366
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is