Clean up OAuth test suite with factories and helper methods #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisad
approved these changes
Aug 10, 2025
| assert field not in data | ||
|
|
||
| # Helper to verify LOLA fields are present and properly formatted | ||
| def assert_has_lola_fields(self, data, actor): |
Member
There was a problem hiding this comment.
I like these helper assert functions
aaronjae22
force-pushed
the
iterate/feedback-from-pr-161
branch
from
4b07de8 to
a826684
Compare
aaronjae22
changed the base branch from
docs/update-oauth-documentation
to
main
Collaborator
Author
|
FYI: the latest activities in this PR (force-pushed and changed the base branch) worked as expected. I tried to use a new approach for working with dependent branches. Each time I'll be working on a big feature I will be able to make small PRs while I continue working on the next one and all of this while keeping the already open PRs and new ones in sync with changes requested during review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #162 . Will retarget to main after PR1 merges.
This PR is stacked on #162 (docs/update-oauth-documentation). Please review #162 first. The base of this PR is set to docs/update-oauth-documentation so the diff only shows commits from iterate/feedback-from-pr-161. After #162 merges, I will retarget the PR to main.
This PR iterates over feedback from PR #161.
ApplicationFactory,AccessTokenFactory)Close #168