Skip to content

Conversation

@aaronjae22
Copy link
Collaborator

@aaronjae22 aaronjae22 commented Jan 27, 2025

Test Suite Updates

Changes Made

  • Updated test structure to support specific Activity types (Create, Like, Follow) instead of generic Activity
  • Added separate fixtures for each activity type in conftest.py
  • Updated API tests to properly handle JSON-LD responses
  • Refined outbox tests to match ActivityPub's OrderedCollection format

Specific Updates:

  1. test_activities.py:

    • Removed generic activity tests
    • Added specific tests for CreateActivity, LikeActivity, and FollowActivity
    • Updated activity string representation tests
  2. test_models.py:

    • Updated outbox tests to handle separate activity collections
    • Added tests for actor creation activities
    • Enhanced JSON-LD structure validation
  3. test_api.py:

    • Updated outbox API tests to expect JSON-LD structure
    • Added validation for ActivityPub OrderedCollection format
    • Improved response structure assertions
  4. conftest.py:

    • Added specific fixtures for each activity type
    • Updated dependencies between fixtures
    • Improved fixture organization

  • All tests pass with updated model structure
  • Verified JSON-LD output matches ActivityPub spec
  • Confirmed proper handling of different activity types in outbox

  • Aligns with ActivityPub spec for activity streams
  • Supports LOLA data portability requirements
  • Improves test coverage for activity-specific functionality

Pytest results

image


@aaronjae22 aaronjae22 requested a review from lisad January 27, 2025 21:29
@aaronjae22 aaronjae22 self-assigned this Jan 27, 2025
@aaronjae22
Copy link
Collaborator Author

@lisad I will go ahead and merge the testsuite updates.

@aaronjae22 aaronjae22 merged commit 9cc2c4f into main Jan 28, 2025
@aaronjae22 aaronjae22 deleted the update-testsuite branch April 2, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update testsuite

1 participant