Skip to content

Conversation

@Y--
Copy link
Contributor

@Y-- Y-- commented Dec 11, 2023

Today, the build_loadable.sh scripts output every extension under loadable_extensions folder.

This PR outputs them under loadable_extensions/$MODE/$FEATURE where MODE and FEATURE are the parameters provided in input to select the source directory (eg. mode=relperf feature=mvp)

That respect the input parameters
Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though about and solving this generally (= in duckdb Makefile), with having a postprocessing step where extensions are copied to build/release/extensions/${duckdb_version}/${platform}/${name}.duckdb_extension[.wasm], since that will also allow to use the folder as a local extension directory, basically SET custom_extension_repository='/path/to/folder';

Stuff might move more that direction, but for not this is still more clean.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants