Skip to content

Handle single quotes #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mytherin merged 1 commit into from
Jan 9, 2024
Merged

Handle single quotes #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/duckdb-wasm/bundle.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,11 @@ fs.copyFile(path.resolve(src, 'bindings', 'duckdb-coi.wasm'), path.resolve(dist,

function patchFile(fileName, moduleName) {
// Patch file to make sure ESBuild doesn't statically analyse and attempt to load "moduleName"
const sedCommand = `s/require("${moduleName}")/["${moduleName}"].map(require)/g`;
// We replace both single and double-quoted module names. The character capture list complexity
// is due to the single quote:
// - the sed expression is executed within single quotes
// - we have to terminate the quotes
// - we have to escape the middle quote
const sedCommand = `s/require(["'\\'']${moduleName}["'\\''])/["${moduleName}"].map(require)/g`;
execSync(`sed -i.bak '${sedCommand}' ${fileName} && rm ${fileName}.bak`);
}