Skip to content

Laravel 11 support fixes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Laravel 11 support fixes #100

wants to merge 7 commits into from

Conversation

timmylindh
Copy link
Contributor

@timmylindh timmylindh commented Mar 15, 2024

When using Laravel 11 with this package, neither schedule or queue works. This should fix it.

  • Manually bootstrap kernel to detect jobs defined in console.php route file. In the case of $this->runSpecificCommand the kernel is bootstrapped by the call to $kernel->call().
  • Autoload service provider
  • Bind Laravel8Worker

@fylzero
Copy link
Collaborator

fylzero commented Mar 16, 2024

@timmylindh Thanks for submitting this - we've previously discussed adding auto discover and for the time being feel it is a potential security risk. Would you mind reverting that out of this PR?

The $kernel->bootstrap(); addition is something we'll need to test - would you mind submitting that in a separate PR?

For this PR - just include the change to src/Integrations/BindsWorker.php and I'll get that added and tagged right away.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants