Skip to content

PR: Add /ping endpoint and image to Wake Heroku Dyno#5

Merged
SimonLab merged 7 commits intomasterfrom
add-ping-to-wake-heroku-dyno
Jun 2, 2020
Merged

PR: Add /ping endpoint and image to Wake Heroku Dyno#5
SimonLab merged 7 commits intomasterfrom
add-ping-to-wake-heroku-dyno

Conversation

@nelsonic
Copy link
Copy Markdown
Member

This PR relates to dwyl/ping#1

@nelsonic nelsonic temporarily deployed to phoenix-content-negotiation May 30, 2020 18:53 Inactive
@nelsonic nelsonic mentioned this pull request May 30, 2020
3 tasks
@nelsonic
Copy link
Copy Markdown
Member Author

@SimonLab hopefully the docs in https://github.com/dwyl/ping are clear enough that the purpose of this PR is obvious. (but if not, please LMK!)

The way to test this is working is to view the README.md of this branch: https://github.com/dwyl/phoenix-content-negotiation-tutorial/tree/add-ping-to-wake-heroku-dyno

And then visit the Heroku app: https://phoenix-content-negotiation.herokuapp.com
It should load instantly rather than having to wait for the dyno to wake.
(because the app was "woken up" by loading the README.md in the browser ...)

Thanks for reviewing/merging. 👍

@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2020

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines           11        13    +2     
=========================================
+ Hits            11        13    +2     
Impacted Files Coverage Δ
lib/app_web/controllers/ping_controller.ex 100.00% <100.00%> (ø)
lib/app_web/router.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae7f4e...b45b3c2. Read the comment docs.

Copy link
Copy Markdown
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonLab SimonLab merged commit 72cb39a into master Jun 2, 2020
@SimonLab SimonLab deleted the add-ping-to-wake-heroku-dyno branch June 2, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants