Delete participations of long inactive users #2329
Conversation
…default of 18 months
…ing months to seconds
…or vote start/end date instead of flat value
…ed as "can_be_marked_inactive_by_manager"
…ed to add +1 to get above threshold
richardebeling
left a comment
richardebeling
left a comment
There was a problem hiding this comment.
Good work so far! Sorry, quite a few comments added up, this could be a bit overwhelming. We want to address everything so we don't get stuck in endless review loops. We're always happy to help out and answer any questions, so make sure to ask if anything is unclear.
Co-authored-by: Richard Ebeling <[email protected]>
Co-authored-by: Richard Ebeling <[email protected]>
Thanks for your time in reviewing this PR, especially for all the fixes and explanations. Much appreciated 👍. |
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
Looks mostly good to me, I only have minor comments:
janno42
left a comment
janno42
left a comment
There was a problem hiding this comment.
In the future, it would probably be nice to have the accounts listed in one message like those to be marked inactive, but I think it's fine for now.
Kakadus
left a comment
Kakadus
left a comment
There was a problem hiding this comment.
requesting the missing test from above
|
should I add full path coverage for |
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
Looks good, only two small suggestions:
Kakadus
requested review from
Kakadus and
niklasmohrin
and removed request for
Kakadus
5 participants
Fixes #2176.
Additionally added two test in class RemoveUserDueToInactivity. During test run of "Bulk update users" in the web with evap/staff/fixtures/test_user_bulk_update_file.txt, Lyndsey Lattimore should get removed from 1 participation(s) due to inactivity..