Add tools/check_dist.py to ensure all specified artifacts are used
#2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ah, this just found another packaging bug: Even though we listed them for inclusion in the wheel, tt turns out we don't generate CSS source maps in This has been the behavior from #1529 onwards, but I don't really see why. @richardebeling @janno42 any idea? |
Member
Author
|
I guess there should be a small test for the script |
richardebeling
previously approved these changes
May 24, 2025
niklasmohrin
changed the title
niklasmohrin
changed the title
niklasmohrin
changed the title
tools/check_dist.py to ensure all specified artifacts are used
hansegucker
requested changes
May 26, 2025
hansegucker
approved these changes
May 26, 2025
richardebeling
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent situations like #2446. I also enabled source map generation for
./manage.py scss --production.Note that I used the
pathspeclibrary instead of the builtinfnmatchmodule, because that is what hatch uses: https://github.com/pypa/hatch/blob/4ebce0e1fe8bf0fcdef587a704c207a063d72575/backend/src/hatchling/builders/config.py#L185