Remove single results #2484
Merged
Remove single results #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janno42
force-pushed
the
remove-single-results
branch
from
087e4ad to
c664d8b
Compare
richardebeling
previously approved these changes
Jul 28, 2025
Member
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
looks good, only a handful of small things
evap/evaluation/migrations/0150_migrate_single_results_to_normal_evaluations.py
Outdated
Show resolved
Hide resolved
evap/evaluation/migrations/0150_migrate_single_results_to_normal_evaluations.py
Outdated
Show resolved
Hide resolved
evap/evaluation/migrations/0150_migrate_single_results_to_normal_evaluations.py
Outdated
Show resolved
Hide resolved
evap/evaluation/migrations/0150_migrate_single_results_to_normal_evaluations.py
Show resolved
Hide resolved
janno42
force-pushed
the
remove-single-results
branch
from
c664d8b to
c0ef65c
Compare
niklasmohrin
previously approved these changes
Jul 31, 2025
Member
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
No more hot single results in this area 😎
evap/evaluation/migrations/0151_migrate_single_results_to_normal_evaluations.py
Show resolved
Hide resolved
janno42
force-pushed
the
remove-single-results
branch
from
c0ef65c to
5a22836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't use single results for several years now. So let's remove lots of special handling!
This migrates all single results into "normal" evaluations with an overall rating questions holding the existing answers and removes all single results logic.