Fix flaky StudentVoteLiveTest.test_resolving_submit_errors_clears_warning
#2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansegucker
approved these changes
Aug 1, 2025
styrix560
pushed a commit
to styrix560/EvaP
that referenced
this pull request
Aug 4, 2025
…rning` (e-valuation#2492) We noticed test failures in CI: ```plain selenium.common.exceptions.StaleElementReferenceException: Message: The element with the reference b70abd94-a473-4dad-ad6f-a8629a9007ae is stale; either its node document is not the active document, or it is no longer connected to the DOM; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#staleelementreferenceexception ``` on the line ```python checkbox = row.find_element(By.CSS_SELECTOR, "input[type=radio][value='2'] + label.choice-error") ``` From the documentation, it seems that the `row` variable becomes stale. This can occur if the browser is slow and the page reload only happens after we assigned the `row` variable initially. To fix this, I inserted a wait command that ensures that the page has reloaded. The other tests in this file don't seem to submit the form, so they should be fine. Note that the CI failure can be reproduced by moving the `row = ` line before the `submit_button.click()` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed test failures in CI:
on the line
From the documentation, it seems that the
rowvariable becomes stale. This can occur if the browser is slow and the page reload only happens after we assigned therowvariable initially. To fix this, I inserted a wait command that ensures that the page has reloaded. The other tests in this file don't seem to submit the form, so they should be fine.Note that the CI failure can be reproduced by moving the
row =line before thesubmit_button.click()call.