Use a global WeakSet to track views that don't require login #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
changed the title
richardebeling
force-pushed
the
anonymous-user-failures
branch
from
8c36719 to
545bd89
Compare
Kakadus
previously approved these changes
Sep 22, 2025
niklasmohrin
requested changes
Sep 23, 2025
richardebeling
force-pushed
the
anonymous-user-failures
branch
from
acdeb5e to
9414b52
Compare
niklasmohrin
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2505. See the issue description for the problem we had with the previous approach.
tags:
@no_login_requiredview func class shared decorator dispatch LoginRequiredMiddleware