-
Notifications
You must be signed in to change notification settings - Fork 165
JSON enrollment importer v2 - part 1 - skip certain course types, use callingname, set is_rewarded correctly, and fix edit rights for contributors #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
985f084 to
056dd1a
Compare
niklasmohrin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; can you make the PR title and comment more descriptive so that we have something more to read in the Git history
1794a93 to
fdb089a
Compare
fdb089a to
f7c791a
Compare
435f2ce to
4450a95
Compare
janno42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested, seems to work :)
Small things you could fix here although they are from v1:
- Newlines between log entries are not consistent: For example after the "Name Changes" block there is no newline before "New Courses"
- Course names sometimes begin with whitespace in the log - the cleaned name should be shown instead.
|
Two more wishes: 🧞
|
5d9a59c to
85841ce
Compare
janno42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Functionality checked
There will be future changes but we can put that in v3 :)
85841ce to
7d52fab
Compare
niklasmohrin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good, some comments:
richardebeling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if the open comments are resolved.
We have a few cases where a later commit overwrites a change of an earlier commit (formatting, narrower type annotation). Not to bad, if you want to rebase-merge we can do that, but I think squash-merge would also work (and clean that up)
7d52fab to
6539ca3
Compare
6539ca3 to
a9af32c
Compare
a9af32c to
f619d33
Compare
f619d33 to
f2579b1
Compare
janno42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Contains only smaller changes of #2500