Make global evaluation progress feature generic #2621
Merged
+89
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansegucker
force-pushed
the
customizable-progress-bar-texts
branch
from
8ea11bd to
b659534
Compare
evap/student/views.py
Outdated
Comment on lines
57
to
58
| title: str | ||
| info_title: str |
Member
There was a problem hiding this comment.
hm, the names are not super great; with the lint warning, maybe we should just make a small dataclass "Campaign" or so inside GlobalEvaluationProgress that has fields title, callout, and description? Then we can also just have one setting of type GlobalEvaluationProgress.Campaign. What do you think?
hansegucker
force-pushed
the
customizable-progress-bar-texts
branch
3 times, most recently
from
ada87d4 to
653598e
Compare
hansegucker
force-pushed
the
customizable-progress-bar-texts
branch
from
653598e to
d52e0c4
Compare
niklasmohrin
approved these changes
Jan 26, 2026
richardebeling
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2617