Keep failed sandboxes in tests alive #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
commented
Oct 31, 2025
| const sandbox = await Sandbox.create(); | ||
| log("ℹ️ sandbox created", sandbox.sandboxId); | ||
|
|
||
| if (Deno.env.get("E2B_DOMAIN") === "e2b-juliett.dev") { |
Member
Author
There was a problem hiding this comment.
removed this as it isn't needed anymore
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sitole
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors periodic tests to use a shared sandbox runner that cleans up on success and extends failed sandboxes for debugging; improves template cleanup and flow in time sync test.
tests/periodic-test/utils.tswithlog,DEBUG_TIMEOUT_MS, andrunTestWithSandboxto manage sandbox execution, auto-kill on success, and keep failed sandboxes alive with connect instructions.runTestWithSandboxincreate-file.ts,internet-works.ts,run-code.ts, andsnapshot-and-resume.ts; remove ad-hoc try/catch/finally and manualkillcalls.internet-works.ts: simplify flow and remove environment-based skip.time-is-synchronized/index.ts):runTestWithSandboxfor the sandboxed check and structured logging.deleteTemplate()helper and ensure template deletion infinallyfor reliable cleanup.e2b.tomlremoval) and template build/parse logic while streamlining execution and error handling.Written by Cursor Bugbot for commit d4f611e. This will update automatically on new commits. Configure here.