fix: template build home directory for relative paths #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
djeebus
reviewed
Nov 4, 2025
djeebus
reviewed
Nov 4, 2025
djeebus
reviewed
Nov 4, 2025
Contributor
djeebus
left a comment
djeebus
left a comment
There was a problem hiding this comment.
It looks straight forward. Is this more intuitive than using the current working directory? What are we solving for here?
dobrac
force-pushed
the
fix-copy-home-directory
branch
from
c660224 to
3469213
Compare
| # Fill the workdir with user home directory if empty | ||
| if [ -z "${workdir}" ]; then | ||
| # Use the owner's home directory | ||
| workdir=$(getent passwd "{{ .WorkdirUserHome }}" | cut -d: -f6) |
There was a problem hiding this comment.
Bug: Template Mismatch Causes Script Execution Error
The copyScriptTemplate references {{ .WorkdirUserHome }} in the getent command, but the copyScriptData struct only defines a User field. This mismatch causes a template execution error when the script attempts to resolve the user's home directory.
dobrac
force-pushed
the
fix-copy-home-directory
branch
from
395f2d5 to
db87d10
Compare
djeebus
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy command now resolves relative target paths from the specified workdir, or falls back to the owner's home directory.
The issue was that as the copy was done always under root, the home directory was always "/root" instead of the correct user one.
Note
Resolve relative copy target paths using the specified workdir or, if absent, the owner’s home directory.
TargetPathbased on providedWorkDir; fallback to owner’s home directory viagetentwhen unset.workdir,cds into it, then computes absolutetargetPath.WorkDirandUserfromcmdMetadatainto the copy script data.Written by Cursor Bugbot for commit db87d10. This will update automatically on new commits. Configure here.