fix: invalid mapping normalization #1441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Revamps header mapping normalization to be non-mutating, adds strict/soft validation with version gating, bumps metadata version to 3, and wires validation into sandbox and inspect tool.
NormalizeMappingsto return a new, non-mutating merged list usingBuildMap.Copy(); merges only adjacent same-BuildIdranges.NormalizeFixVersionandHeader.IsNormalizeFixApplied(); enforce bounds/alignment and negative-length checks inGetShiftedMapping/getMappingwith errors for v3+ and warnings for older headers.metadataVersionto3inserialization.go.NormalizeMappingsedge cases.header.ValidateMappings; fail for v3+, otherwise log warnings with build ID.inspect-header): RunValidateMappingson deserialized header and print warning if invalid.Written by Cursor Bugbot for commit 9290e96. This will update automatically on new commits. Configure here.