Support template creation in local dev #1445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
This reverts commit 1a173bb.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/orchestrator/internal/template/build/commands/test_script.sh
Outdated
Show resolved
Hide resolved
djeebus
commented
Nov 6, 2025
| return fmt.Errorf("%s %w", a.errorMessage, err) | ||
| } | ||
|
|
||
| telemetry.ReportEvent(ctx, "api key extracted") |
Contributor
Author
There was a problem hiding this comment.
This was spamming me locally, and seemed useless. Happy to bring it back if it's useful though.
djeebus
commented
Nov 6, 2025
| @@ -0,0 +1,66 @@ | |||
| package sandbox | |||
Contributor
Author
There was a problem hiding this comment.
This was moved out of the shared package and into orchestrator, without changes
Contributor
Author
|
Superseded by #1449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/shared/pkg/storageand intopackages/orchestrator/internal/pathsNote
Enables local template creation by moving path logic into orchestrator, making env paths absolute with auto dir creation, and plumbing config/paths through build, sandbox, and server layers.
BuilderConfigwith path fields (e.g.,DefaultCachePath,TemplateCacheDir,TemplatesDir, etc.), absolutize them, and ensure directories are created on startup.cfg.BuilderConfigthrough builders, servers, sandbox, and cache.packages/orchestrator/internal/paths(TemplateFiles,TemplateCacheFiles,SandboxFiles) replacing usages frompackages/shared/pkg/storage.build.Builder, phases, cache/index, rootfs/envd), and snapshotting (tmp memfile acquisition moved into orchestrator).BuilderConfig; pause/create flows buildpaths.TemplateFilesviapaths.NewWithVersions.cmd/*utilities (build/inspect/simulate) to new paths/config APIs..env.localfor orchestrator with local dirs;make run-localbuilds and runs withsudoand prepares dirs.download-public-kernelsmake target and ignore/packages/fc-kernels.DEV-LOCAL.mdwith new steps; addpackages/shared/scriptsmake target to build base template..env.localadds local cluster settings.Written by Cursor Bugbot for commit 75af051. This will update automatically on new commits. Configure here.