-
Notifications
You must be signed in to change notification settings - Fork 219
Populate redis #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakubno
merged 18 commits into
main
from
make-api-service-populate-redis-store-eng-3060
Nov 20, 2025
Merged
Populate redis #1446
jakubno
merged 18 commits into
main
from
make-api-service-populate-redis-store-eng-3060
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35f94ee to
9309d33
Compare
dobrac
requested changes
Nov 11, 2025
Contributor
dobrac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is beautiful 🌸
# Conflicts: # packages/api/internal/sandbox/sandbox.go
86b6ed1 to
b9b2281
Compare
dobrac
reviewed
Nov 20, 2025
Co-authored-by: Jakub Dobry <[email protected]>
dobrac
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan for migration:
Note
Introduce a new pluggable sandbox store with Redis population, refactor orchestrator/handlers to use context-aware store APIs, and enable Redis in CI.
sandbox.StorewrappingStorageandReservationStoragewith context-aware APIs (Add/Get/Update/Remove/Reserve/Release,Sync).sandbox/storage/memoryand Redis backendsandbox/storage/redis(withredislock), pluspopulate_rediswrapper to mirror writes to Redis.reservationspackage replacing in-memory reservations; comprehensive tests added.sandbox.Sandbox.GetSandbox, create/keep-alive/delete flows to passctxand new store methods; handle add errors and cleanup; use storeSyncfrom nodes; update evictor and team metrics to accept*sandbox.Store.nodemanager.Node.Sync) to use storeSync.ctxtoorchestrator.GetSandboxacross connect/get/pause/kill/resume..github/actions/start-services/action.ymland exportREDIS_URL.github.com/bsm/redislock; keepgo-redisusage.Written by Cursor Bugbot for commit f58b5eb. This will update automatically on new commits. Configure here.