Support envd proxying via header as well as host #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
djeebus
changed the title
| t.Fatalf("ParseHost(%q) error type = %T, want %T", tt.host, err, tt.wantErr) | ||
| } | ||
| if tt.wantErrAs != nil { | ||
| require.ErrorAs(t, err, &tt.wantErrIs) // nolint:testifylint // doesn't need to |
There was a problem hiding this comment.
Bug: Error Type Mismatch in Test Validation
The require.ErrorAs call incorrectly uses &tt.wantErrIs instead of &tt.wantErrAs. This causes the test to check the wrong expected error type when wantErrAs is set, making the test validate against an uninitialized or incorrect error value rather than the intended error type.
ValentaTomas
reviewed
Nov 8, 2025
packages/shared/pkg/proxy/host.go
Outdated
| } | ||
|
|
||
| const ( | ||
| headerSandboxID = "X-Sandbox-Id" |
ValentaTomas
approved these changes
Nov 8, 2025
Member
ValentaTomas
left a comment
ValentaTomas
left a comment
There was a problem hiding this comment.
Left comments, but lgtm otherwise.
djeebus
added a commit
to e2b-dev/E2B
that referenced
this pull request
Nov 14, 2025
This requires [infra#1448](e2b-dev/infra#1448) first. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds support to override the sandbox API URL (E2B_SANDBOX_URL) across JS/Python SDKs, centralizes sandbox host/url logic with headers, and updates CI to build the SDK before CLI. > > - **SDKs (JS & Python)** > - Add `sandboxUrl` support in `ConnectionConfig` (env var `E2B_SANDBOX_URL`), with new helpers `getSandboxUrl`/`getHost` and shared `envdPort`. > - Refactor sandbox initialization to use `ConnectionConfig.getSandboxUrl(...)` and `getHost(...)`. > - Always attach sandbox headers `E2b-Sandbox-Id` and `E2b-Sandbox-Port` to sandbox and connect requests. > - Python: thread `sandbox_url` through opts; update async/sync connect calls to pass headers; minor fix to default `headers=None` in `e2b_connect.client.Client` stream prep. > - **CI** > - Build `packages/js-sdk` before `packages/cli`; set step `working-directory` for build/test. > - **Dependencies** > - Point `e2b` dependency in lockfile to local `../js-sdk` link. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5dc5817. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is here to support local dev, but might be useful in production as well?
Note
Enable header-based sandbox routing in proxies and centralize/refine proxy errors; update handlers/tests and tweak orchestrator error message.
packages/shared/pkg/proxy):GetTargetFromRequest(processHeaders)to parse sandbox target from headers (E2b-Sandbox-Id,E2b-Sandbox-Port) or fallback to host viaparseHost.ErrInvalidHost,InvalidSandboxPortError(with port),MissingHeaderError; moveSandboxNotFoundErrorintoerrors.go.TestGetTargetFromRequest, covering header and host cases.packages/client-proxy/internal/proxy/proxy.go): UseGetTargetFromRequest(env.IsLocal())for destination resolution.packages/orchestrator/internal/proxy/proxy.go): Same header-aware target resolution.Written by Cursor Bugbot for commit 1dda59d. This will update automatically on new commits. Configure here.