-
Notifications
You must be signed in to change notification settings - Fork 219
Allow optional sandbox ingress traffic auth #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
675404f to
d40cc3c
Compare
5f943bf to
2b528e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Changes added, only unresolved thing now is #1474 (comment). @jakubno |
allowPublicAccess: falseduring sandbox creation and access token needed for sbx traffic.Note
Adds optional private sandbox ingress that requires a per-sandbox traffic access token, enforced by the proxy, with API/proto updates and tests.
allowPublicTraffictoSandboxNetworkConfigand exposetrafficAccessTokenonSandboxresponses.network.ingressand validate: disallow non-public traffic unlesssecure(envd) is enabled; generateEnvdAccessTokenvia new generator.EnvdAccessTokenGeneratorwith unifiedAccessTokenGeneratorsupportingGenerateEnvdAccessTokenandGenerateTrafficAccessToken.APIStoreandOrchestrator.ingress.traffic_access_token(proto + generated pb).trafficAccessTokenwhenAllowPublicAccessis false; pass through to runtime sandbox and network config.AllowPublicAccess.x-e2b-traffic-access-tokenfor sandboxes with private ingress; add specific errors and browser-friendly HTML templates for missing/invalid token.SandboxNetworkIngressConfigand ingress toSandboxNetworkConfig(persisted for pause/resume).secureenvd flag.Written by Cursor Bugbot for commit c6889f7. This will update automatically on new commits. Configure here.