-
Notifications
You must be signed in to change notification settings - Fork 219
Setup valkey cluster with enabled TLS #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup valkey cluster with enabled TLS #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sitole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note
Adds a GCP Memorystore Valkey cluster with TLS, outputs its secure URL and CA via Secret Manager, and wires these through modules; bumps google provider to 6.50.0.
memorystore.googleapis.comand add PSC policy for Valkey (google_network_connectivity_service_connection_policy.valkey).google_memorystore_instance.valkey_cluster(VALKEY_8_0, CLUSTER, multi-zone, AOF, server-auth TLS).redis-tls-ca-base64,redis-secure-cluster-urlwith initial versions andignore_changesfor placeholder data.initand pass toredismodule; add variables (shard_count,replica_count, secret version inputs).hashicorp/googlefrom6.49.3to6.50.0.Written by Cursor Bugbot for commit 2cbfe62. This will update automatically on new commits. Configure here.