fix: speed up provisioning shutdown #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dobrac
force-pushed
the
speed-up-provisioning-shutdown
branch
from
b856cee to
a7ce236
Compare
| return nil, err | ||
| } | ||
|
|
||
| if int64(n) != m.blockSize { |
Member
There was a problem hiding this comment.
Should be ok, just thinking if there is no way the last block/page can be short (it would violate other assumptions though.)
| defer tf.Close(s.config) | ||
|
|
||
| // The snapfile is required only because the FC API doesn't support passing /dev/null | ||
| snapfile := template.NewLocalFileLink(tf.CacheSnapfilePath(s.config)) |
Member
There was a problem hiding this comment.
In the modified FC, would you prefer to have an ability to skip snapfile too/have it delivered as returned body from pause, that you can then more easily discard?
Contributor
Author
There was a problem hiding this comment.
For this use case, yes, accepting it in body or be able to put there /dev/null would be useful. But before that, let's see if it's desired that the reboot doesn't flush. Waiting on a reply from the FC team
ValentaTomas
approved these changes
Nov 19, 2025
Member
ValentaTomas
left a comment
ValentaTomas
left a comment
There was a problem hiding this comment.
Left some comments that I would like to sync on, but otherwise lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce Sandbox.Shutdown for faster, clean VM teardown during provisioning; ensure full block writes in diff export and add cache cleanup for template cache files.
Sandbox.Shutdown(ctx)to pause VM, disable uffd, snapshot to temp files, and close resources.Shutdownin base provision phase instead ofPausesnapshot workflow; remove unused snapshot handling.block/cache.ExportToDiff, verify full block writes by checkingnagainstblockSizeand error on short write.TemplateCacheFiles.Close(config)to remove cache dir; used bySandbox.Shutdown.Written by Cursor Bugbot for commit a7ce236. This will update automatically on new commits. Configure here.