Fix issue when files for paused sandbox are not uploaded yet #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
commented
Dec 15, 2025
| // and current load distribution. | ||
| type Algorithm interface { | ||
| chooseNode(ctx context.Context, nodes []*nodemanager.Node, nodesExcluded map[string]struct{}, requested nodemanager.SandboxResources, buildMachineInfo machineinfo.MachineInfo) (*nodemanager.Node, error) | ||
| excludeNode(err error) bool |
Member
Author
There was a problem hiding this comment.
simplified the logic a little
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dobrac
requested changes
Dec 15, 2025
jakubno
deleted the
fix-issue-when-files-for-paused-sandbox-are-not-uploaded-yet-eng-3395
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Handle missing snapshot files with FailedPrecondition and refine placement to skip exhausted nodes and retry, adding supporting test helpers and tests.
packages/orchestrator/internal/server/sandboxes.go):FailedPreconditionwhen snapshot/template files are missing (storage.ErrObjectNotExist), with telemetry.packages/api/internal/orchestrator/placement):Algorithminterface (removeexcludeNode).ResourceExhausted, otherwise exclude the node, record failure, and increment attempts.nodemanager/mock.go):ResourceExhaustedand succeeds on another node.CreatereturnsFailedPreconditionwhen sandbox files are not found.Written by Cursor Bugbot for commit 3ee22ce. This will update automatically on new commits. Configure here.