Skip to content

Conversation

@dobrac
Copy link
Contributor

@dobrac dobrac commented Dec 17, 2025

Note

Handle backward log direction by reversing in the server and simplify cache GetLogs to always return ascending logs.

  • Template build logs:
    • Server (template_status.go): Fetch logs once, reverse when direction == Backward, apply filters/offset/limit, then reverse result back to ascending to return consistent order.
    • Cache (build_cache.go): Simplify BuildInfo.GetLogs() to no-arg returning all log lines; remove in-method direction handling.

Written by Cursor Bugbot for commit 44f2459. This will update automatically on new commits. Configure here.

@dobrac dobrac added the bug Something isn't working label Dec 17, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT

@dobrac dobrac enabled auto-merge (squash) December 17, 2025 09:59
@dobrac dobrac disabled auto-merge December 17, 2025 10:06
@dobrac dobrac enabled auto-merge (squash) December 17, 2025 10:07
@dobrac dobrac merged commit 83d0056 into main Dec 17, 2025
27 checks passed
@dobrac dobrac deleted the fix/template-build-logs-entries branch December 17, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants